[Console] Fix autocomplete multibyte input support #34558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and please add a test case if possible :) |
fancyweb
force-pushed
the
console-fix-question-helper
branch
from
d67c7ea
to
dffe932
Compare
fancyweb
force-pushed
the
console-fix-question-helper
branch
from
dffe932
to
a1129f9
Compare
|
I used existing helper functions and added a test case. |
chalasr
approved these changes
Nov 29, 2019
nicolas-grekas
approved these changes
Nov 29, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Console] Fix autocomplete multibyte input support | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34254 | License | MIT | Doc PR | - Added it just where it's needed. Commits ------- a1129f9 [Console] Fix autocomplete multibyte input support
This was referenced Dec 1, 2019
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added it just where it's needed.