[Finder] Allow ssh2 stream wrapper for sftp #34396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same fix as #28604 but for the ss2.sftp wrapper.
nicolas-grekas
approved these changes
Nov 15, 2019
lyrixx
approved these changes
Nov 15, 2019
|
Thank you @damienalexandre. |
fabpot
added a commit
that referenced
this pull request
Nov 15, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Finder] Allow ssh2 stream wrapper for sftp Same fix as #28604 but for the ssh2.sftp wrapper. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #28604 maybe | License | MIT | Doc PR | Without this patch, we can't use the finder with ssh2.sftp connections. ```php $connection = \ssh2_connect('host', 22); \ssh2_auth_password($connection, 'user', 'pass'); $sftp = \ssh2_sftp($connection); $path = "ssh2.sftp://".intval($sftp)."/"; $finder = new Finder(); foreach ($finder->in($path)->files() as $directory) { dump(file_get_contents($directory)); } ``` Without the patch: > RecursiveDirectoryIterator::__construct(ssh2.sftp://838): failed to open dir: operation failed Commits ------- e6c9d77 [Finder] Allow ssh2 stream wrapper for sftp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as #28604 but for the ssh2.sftp wrapper.
Without this patch, we can't use the finder with ssh2.sftp connections.
Without the patch: