Avoid empty "If-Modified-Since" header in validation request #34385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 15, 2019
|
Can you add a test covering this ? |
|
@stof You agree it makes sense to put this into the existing test method? (Yes, that test now fails if I revert the initial change.) |
stof
approved these changes
Nov 23, 2019
|
Thank you @mpdude. |
stof
added a commit
that referenced
this pull request
Nov 23, 2019
…st (mpdude) This PR was squashed before being merged into the 3.4 branch (closes #34385). Discussion ---------- Avoid empty "If-Modified-Since" header in validation request | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Just noticed that when a response has been cached that is `public` and has an `maxAge` but does _not_ provide `Last-Modified`, the validation subrequest will have an empty `If-Modified-Since` header value. Commits ------- 960faef Avoid empty \"If-Modified-Since\" header in validation request
This was referenced Dec 1, 2019
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that when a response has been cached that is
publicand has anmaxAgebut does not provideLast-Modified, the validation subrequest will have an emptyIf-Modified-Sinceheader value.