[FrameworkBundle] [HttpKernel] fixed correct EOL and EOM month #34203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deveric86
commented
Oct 31, 2019
•
deveric86
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
deveric86
changed the title
deveric86
force-pushed
the
master
branch
2 times, most recently
from
5b0dbbb
to
6cf4bd9
Compare
deveric86
changed the title
ro0NL
approved these changes
Oct 31, 2019
|
(bugfix for 3.4 i'd say) |
deveric86
changed the title
|
@ro0NL Can you tell me what's wrong with this PR, why does fabbot.io fails? |
fabpot
approved these changes
Nov 3, 2019
* Added a hardcoded day 01 in order to output the proper month November
which is the correct EOL and EOM month.
* \DateTime::createFromFormat('mY') will output December for every month
where day 31 exists.
|
Thank you @deveric86. |
fabpot
added a commit
that referenced
this pull request
Nov 3, 2019
…onth (erics86) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #34203). Discussion ---------- [FrameworkBundle] [HttpKernel] fixed correct EOL and EOM month Q | A -- | -- Branch? | 3.4 Bug fix? | yes New feature? | no Deprecations? | no Tickets | - License | MIT Doc PR | - Commits ------- 613717d [FrameworkBundle] [HttpKernel] fixed correct EOL and EOM month
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.