[Stopwatch] Fixed bug in getDuration when counting multiple ongoing periods #34181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
fabpot
approved these changes
Nov 3, 2019
|
Thank you @TimoBakx. |
fabpot
added a commit
that referenced
this pull request
Nov 3, 2019
…e ongoing periods (TimoBakx) This PR was merged into the 3.4 branch. Discussion ---------- [Stopwatch] Fixed bug in getDuration when counting multiple ongoing periods | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34087 | License | MIT | Doc PR | N/A When running multiple periods in StopwatchEvent (start multiple times and not stop them all), the getDuration() method would return unexpected values. This was because at every stop, the last entry in the `started` array was removed, while the `getDuration` method was still expecting all the started events to still be there. Now, when calling `getDuration`, the duration of all the finished periods are added together with the unfinished counts. Commits ------- af00d8d [Stopwatch] Fixed bug in getDuration when counting multiple ongoing periods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running multiple periods in StopwatchEvent (start multiple times and not stop them all), the getDuration() method would return unexpected values.
This was because at every stop, the last entry in the
startedarray was removed, while thegetDurationmethod was still expecting all the started events to still be there.Now, when calling
getDuration, the duration of all the finished periods are added together with the unfinished counts.