[Stopwatch] Fixed a bug in StopwatchEvent::getStartTime #34179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Oct 31, 2019
fabpot
approved these changes
Nov 3, 2019
|
Thank you @TimoBakx. |
fabpot
added a commit
that referenced
this pull request
Nov 3, 2019
…imoBakx) This PR was merged into the 3.4 branch. Discussion ---------- [Stopwatch] Fixed a bug in StopwatchEvent::getStartTime | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34088 | License | MIT | Doc PR | N/A When using a `StopwatchEvent` with an `$origin` that's smaller than the first start time, calling `getStartTime()` before ending the event will give `0` instead of the correct number. The proposed fix in #34088 fixes this. Commits ------- b2b7eab [Stopwatch] Fixed a bug in stopwatch event getStartTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
StopwatchEventwith an$originthat's smaller than the first start time, callinggetStartTime()before ending the event will give0instead of the correct number.The proposed fix in #34088 fixes this.