[Serializer] Improve messages for unexpected resources values #34144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
serializer-better-message-for-resources
branch
from
e26d257
to
fe54704
Compare
|
What about: An unexpected value (“stream”) could not be serialized. It reads more fluently |
|
@OskarStark It might be read it as the |
dunglas
approved these changes
Oct 28, 2019
fancyweb
force-pushed
the
serializer-better-message-for-resources
branch
from
fe54704
to
ad2ce27
Compare
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 30, 2019
…ues (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [Serializer] Improve messages for unexpected resources values | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Before: `An unexpected value could not be serialized: NULL` - very misleading After: `An unexpected value could not be serialized: a "stream" resource` Commits ------- ad2ce27 [Serializer] Improve messages for unexpected resources values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
An unexpected value could not be serialized: NULL- very misleadingAfter:
An unexpected value could not be serialized: a "stream" resource