Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix paths to detect code owners #34127

Merged
merged 1 commit into from Oct 26, 2019
Merged

fix paths to detect code owners #34127

merged 1 commit into from Oct 26, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 26, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

I was wondering why sometimes I didn't receive any notifications for PRs where I thought a file for which I claimed code ownership was modified. Turns out according to https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax the dir/* pattern does not include nested directories.

@xabbuh xabbuh added this to the 3.4 milestone Oct 26, 2019
@fabpot
Copy link
Member

fabpot commented Oct 26, 2019

Thank you @xabbuh.

fabpot added a commit that referenced this pull request Oct 26, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

fix paths to detect code owners

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

I was wondering why sometimes I didn't receive any notifications for PRs where I thought a file for which I claimed code ownership was modified. Turns out according to https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax the `dir/*` pattern does not include nested directories.

Commits
-------

cb7523d fix paths to detect code owners
@fabpot fabpot merged commit cb7523d into symfony:3.4 Oct 26, 2019
@xabbuh xabbuh deleted the code-owners branch October 26, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants