[PropertyInfo] Respect property name case when guessing from public method name #33948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure the failing test are related 🤔 |
nicolas-grekas
changed the title
nicolas-grekas
approved these changes
Oct 12, 2019
fabpot
approved these changes
Oct 13, 2019
|
Thank you @antograssiot. |
fabpot
added a commit
that referenced
this pull request
Oct 13, 2019
…om public method name (antograssiot) This PR was merged into the 3.4 branch. Discussion ---------- [PropertyInfo] Respect property name case when guessing from public method name | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #32656 | License | MIT | Doc PR | Using camelCase, with an attribute `$aFooBar`, naming the getter/setter `getAFooBar()`/`setAFooBar()`, returns the property name as AFooBar instead of aFooBar. # Before Property name `'AFooBar'` # After Property name `'aFooBar'` as expected Commits ------- 843bb76 [PropertyInfo] Respect property name case when guessing from public method name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using camelCase, with an attribute
$aFooBar, naming the getter/settergetAFooBar()/setAFooBar(), returns the property name as AFooBar instead of aFooBar.Before
Property name
'AFooBar'After
Property name
'aFooBar'as expected