[VarDumper] fix resetting the "bold" state in CliDumper #33943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 10, 2019
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
|
do we need the same for other non-bold styles ? |
|
@stof that's already what the remaining of the default style does to me. I didn't notice any other issues. |
|
So, only |
|
It looks like so: there is always a default-styled character between any other style (even just a space). |
javiereguiluz
approved these changes
Oct 11, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Oct 11, 2019
…icolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] fix resetting the "bold" state in CliDumper | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 21645a5 [VarDumper] fix resetting the "bold" state in CliDumper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.