Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yaml] Throw exception for tagged invalid inline elements #33818

Merged
merged 1 commit into from Oct 18, 2019
Merged

[Yaml] Throw exception for tagged invalid inline elements #33818

merged 1 commit into from Oct 18, 2019

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Oct 2, 2019 •
edited

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

At the moment the result for !foo 'don't do somthin' like that' is a TaggedValue with value "don".

@gharlan gharlan requested a review from xabbuh as a code owner October 2, 2019 17:40
@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Oct 2, 2019
xabbuh
xabbuh previously approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a minor comment, should be merged into 3.4 if I don't miss anything

src/Symfony/Component/Yaml/Tests/InlineTest.php Outdated Show resolved Hide resolved
@xabbuh xabbuh modified the milestones: 4.3, 3.4 Oct 15, 2019
@gharlan
Copy link
Contributor Author

gharlan commented Oct 15, 2019

should be merged into 3.4 if I don't miss anything

Tagged scalars were introduced in 4.0.

@xabbuh xabbuh modified the milestones: 3.4, 4.3 Oct 15, 2019
@gharlan
Copy link
Contributor Author

gharlan commented Oct 15, 2019 •
edited

Oh, but it seems that tagged inline arrays are also affected (in 3.4).

!foo [bar] baz

This does not throw an exception.

So I will change target to 3.4 and fix it there.

Status: Needs Work

@xabbuh xabbuh dismissed their stale review October 15, 2019 09:44

wait for 3.4 fixes

@gharlan gharlan changed the title [Yaml] Throw exception for invalid tagged scalar [Yaml] Throw exception for tagged invalid inline elements Oct 15, 2019
@gharlan gharlan changed the base branch from 4.3 to 3.4 October 15, 2019 22:09
@gharlan gharlan requested a review from xabbuh October 15, 2019 22:17
@xabbuh
Copy link
Member

xabbuh commented Oct 18, 2019

Thank you @gharlan.

xabbuh added a commit that referenced this pull request Oct 18, 2019
@xabbuh
bug #33818 [Yaml] Throw exception for tagged invalid inline elements …
52f8fc8 
…(gharlan)

This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] Throw exception for tagged invalid inline elements

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

At the moment the result for `!foo 'don't do somthin' like that'` is a `TaggedValue` with value "don".

Commits
-------

bed479c [Yaml] Throw exception for tagged invalid inline elements
@xabbuh xabbuh merged commit bed479c into symfony:3.4 Oct 18, 2019
@gharlan gharlan deleted the yaml-tag-fix branch October 18, 2019 09:30
This was referenced Nov 1, 2019
Merged
Merged
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gharlan @xabbuh @nicolas-grekas @carsonbot