[DependencyInjection] Fixed the getServiceIds implementation to always return aliases
#33335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why is it a draft PR ? What is left to do with it ? |
|
Nothing, wanted to check it over myself briefly. |
nicolas-grekas
approved these changes
Aug 26, 2019
chalasr
approved these changes
Aug 26, 2019
fabpot
approved these changes
Aug 26, 2019
…ays return aliases
fabpot
force-pushed
the
fix-getserviceids
branch
from
b4433f6
to
834d5cb
Compare
|
Thank you @pvandommelen. |
fabpot
added a commit
that referenced
this pull request
Aug 26, 2019
…tion to always return aliases (pdommelen) This PR was squashed before being merged into the 3.4 branch (closes #33335). Discussion ---------- [DependencyInjection] Fixed the `getServiceIds` implementation to always return aliases | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | maybe | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33307 | License | MIT | Doc PR | - Changed the getServiceIds implementation in the Container base class to include aliases. Modified existing tests. Added test which uses the PhpDumper. Fixes #33307 Without this patch the implementations of the container are inconsistent in whether or not they return aliases (see issue). Fixing this could be considered a BC break for the affected Container class. As an alternative to keep the behaviour in Container unchanged, the dumped container could be patched instead. And then only apply this version of the patch to master. This however keeps the inconsistency between Container and ContainerBuilder. Commits ------- 834d5cb [DependencyInjection] Fixed the `getServiceIds` implementation to always return aliases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the getServiceIds implementation in the Container base class to include aliases. Modified existing tests. Added test which uses the PhpDumper.
Fixes #33307
Without this patch the implementations of the container are inconsistent in whether or not they return aliases (see issue). Fixing this could be considered a BC break for the affected Container class.
As an alternative to keep the behaviour in Container unchanged, the dumped container could be patched instead. And then only apply this version of the patch to master. This however keeps the inconsistency between Container and ContainerBuilder.