Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] fixed a PHP notice when there is no function in the stack trace of an Exception #33172

Merged
merged 1 commit into from Aug 15, 2019

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Aug 14, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Under certain circumstances, the function is not present in the stack trace. That's the case for instance when an error occurs on a line like this one return require "somefile";.

@fabpot fabpot changed the title [Console] fixed a PHP notice when there is no function [Console] fixed a PHP notice when there is no function in the stack trace of an Exception Aug 14, 2019
@chalasr chalasr added this to the 3.4 milestone Aug 14, 2019
@nicolas-grekas
Copy link
Member

Thank you @fabpot.

@nicolas-grekas nicolas-grekas merged commit ddb4735 into symfony:3.4 Aug 15, 2019
nicolas-grekas added a commit that referenced this pull request Aug 15, 2019
…the stack trace of an Exception (fabpot)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] fixed a PHP notice when there is no function in the stack trace of an Exception

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Under certain circumstances, the `function` is not present in the stack trace. That's the case for instance when an error occurs on a line like this one `return require "somefile";`.

Commits
-------

ddb4735 [Console] fixed a PHP notice when there is no function
This was referenced Aug 26, 2019
@fabpot fabpot deleted the notice-removal branch September 6, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants