Fix getMaxFilesize() returning zero #33157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
force-pushed
the
fix/get-max-filesize
branch
from
3776298
to
f4c2ea5
Compare
|
I didn’t find a way to mock the |
fabpot
approved these changes
Aug 14, 2019
|
Thank you @ausi. |
fabpot
added a commit
that referenced
this pull request
Aug 14, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Fix getMaxFilesize() returning zero | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32790 | License | MIT With #32790 a BC break got introduced. Previously an empty `upload_max_filesize` returned `PHP_INT_MAX` but after the changes from #32790 it returns `0`. Setting `upload_max_filesize` or `post_max_size` to `0` or `''` disables the limit so for both cases `PHP_INT_MAX` should be returned. Commits ------- f4c2ea5 Fix getMaxFilesize() returning zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #32790 a BC break got introduced. Previously an empty
upload_max_filesizereturnedPHP_INT_MAXbut after the changes from #32790 it returns0.Setting
upload_max_filesizeorpost_max_sizeto0or''disables the limit so for both casesPHP_INT_MAXshould be returned.