[Intl] Cleanup unused language aliases entry #33139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakzal
approved these changes
Aug 13, 2019
fabpot
approved these changes
Aug 13, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Aug 13, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] Cleanup unused language aliases entry | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> The data entry `Aliases` in languages is never used. https://github.com/symfony/symfony/blob/50c59112298669e7724a42a8ee1a1fe6d1e1b536/src/Symfony/Component/Intl/Data/Provider/LanguageDataProvider.php#L44-L47 Already crashes with ``` Symfony\Component\Intl\Exception\MissingResourceException: Couldn't read the indices [Aliases] for the locale "root" in "src/Symfony/Component/Intl/Resources/data/languages". ``` The locale should be `meta`, which would return an empty array 🤷♂️ Commits ------- 1689f77 [Intl] Cleanup unused language aliases entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data entry
Aliasesin languages is never used.symfony/src/Symfony/Component/Intl/Data/Provider/LanguageDataProvider.php
Lines 44 to 47 in 50c5911
Already crashes with
The locale should be
meta, which would return an empty array 🤷♂️