[Intl] Support DateTimeInterface in IntlDateFormatter::format #32947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vudaltsov
approved these changes
Aug 5, 2019
|
Shouldn't it be merged into |
pierredup
force-pushed
the
intdateformatter
branch
from
73044d6
to
b1e160c
Compare
|
@xabbuh Indeed, thanks. I've switched the base to 3.4 |
xabbuh
approved these changes
Aug 5, 2019
nicolas-grekas
approved these changes
Aug 5, 2019
|
Thank you @pierredup. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 5, 2019
…mat (pierredup) This PR was merged into the 3.4 branch. Discussion ---------- [Intl] Support DateTimeInterface in IntlDateFormatter::format | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32898 | License | MIT | Doc PR | N/A Add support for `DateTimeInterface` to `IntlDateFormatter::format` which is supported since PHP 7.1.5. Since this component supports PHP from 7.1.3, should version checks be added, to only support DateTimeInterface if PHP is >= 7.1.5 or should the minimum required PHP version bumped to 7.1.5? Commits ------- b1e160c Support DateTimeInterface in IntlDateFormatter::format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
DateTimeInterfacetoIntlDateFormatter::formatwhich is supported since PHP 7.1.5.Since this component supports PHP from 7.1.3, should version checks be added, to only support DateTimeInterface if PHP is >= 7.1.5 or should the minimum required PHP version bumped to 7.1.5?