Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl] Order alpha2 to alpha3 mapping #32918

Merged
merged 1 commit into from Aug 5, 2019
Merged

[Intl] Order alpha2 to alpha3 mapping #32918

merged 1 commit into from Aug 5, 2019

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Aug 4, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32676 (comment)
License MIT
Doc PR symfony/symfony-docs#...

to move forward with #32676

@fabpot
Copy link
Member

fabpot commented Aug 5, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit 724f1f5 into symfony:3.4 Aug 5, 2019
fabpot added a commit that referenced this pull request Aug 5, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Intl] Order alpha2 to alpha3 mapping

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32676 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

to move forward with #32676

Commits
-------

724f1f5 [Intl] Order alpha2 to alpha3 mapping
fabpot added a commit that referenced this pull request Aug 5, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Intl] Order alpha2 to alpha3 mapping + phpdoc fixes

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32676 (review)
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

includes #32918

Commits
-------

867e3de [Intl] Order alpha2 to alpha3 mapping + phpdoc fixes
@ro0NL ro0NL deleted the intl-order branch August 5, 2019 06:10
This was referenced Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants