[PhpUnitBridge] Allow sutFqcnResolver to return array #32902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you revert the array() => [] changes please? |
nicolas-grekas
changed the title
Yes, but I had an error from symfony linter |
I know, it's just a tool, and as all tools it has its limits, this is one of them :) |
nicolas-grekas
approved these changes
Aug 3, 2019
|
Thank you @VincentLanglet. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 4, 2019
…centLanglet) This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Allow sutFqcnResolver to return array | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... | License | MIT | Doc PR | Phpunit handle multiple covers annotation: ``` /** * @Covers ClassOne * @Covers ClassTwo */ ``` The coverage solver was only allowed to return `ClassOne` or `ClassTwo` since it was transformed to `[ClassName]`. Returning `[ClassOne, ClassTwo]` was transform to [[ClassOne, ClassTwo]]` which was creating an error with phpunit. This PR fixed this case. Commits ------- 1451c0b Allow sutFqcnResolver to return array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phpunit handle multiple covers annotation:
The coverage solver was only allowed to return
ClassOneorClassTwosince it was transformed to[ClassName]. Returning[ClassOne, ClassTwo]was transform to [[ClassOne, ClassTwo]]` which was creating an error with phpunit. This PR fixed this case.