Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#32853 Check if $this->parameters is array. #32870

Merged
merged 1 commit into from Aug 3, 2019
Merged

#32853 Check if $this->parameters is array. #32870

merged 1 commit into from Aug 3, 2019

Conversation

ABGEO
Copy link
Contributor

@ABGEO ABGEO commented Aug 1, 2019 •
edited

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Tests pass? yes
Fixed tickets #32853
License MIT

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 2, 2019
@nicolas-grekas
Copy link
Member

Would it work if we initializer the property to the empty array when it is declared instead?
The fix should target branch 3.4 btw, thanks.

@ABGEO
Copy link
Contributor Author

ABGEO commented Aug 3, 2019 •
edited

Would it work if we initializer the property to the empty array when it is declared instead?
The fix should target branch 3.4 btw, thanks.

@nicolas-grekas Yes, it will. If the array is empty, it will return false.

@nicolas-grekas
Copy link
Member

Great, can you update the patch then please?

@ABGEO
Copy link
Contributor Author

ABGEO commented Aug 3, 2019

What do you mean by updating the patch? :)

@nicolas-grekas
Copy link
Member

I mean: change the patch to initialize the property, and revert the current changes.

@ABGEO
Copy link
Contributor Author

ABGEO commented Aug 3, 2019

@nicolas-grekas Done and it works.

@nicolas-grekas nicolas-grekas changed the base branch from 4.3 to 3.4 August 3, 2019 18:12
@nicolas-grekas
Copy link
Member

Thank you @ABGEO07.

@nicolas-grekas nicolas-grekas merged commit 7cf9ed6 into symfony:3.4 Aug 3, 2019
nicolas-grekas added a commit that referenced this pull request Aug 3, 2019
@nicolas-grekas
bug #32870 #32853 Check if $this->parameters is array. (ABGEO07)
8890be6 
This PR was submitted for the 4.3 branch but it was squashed and merged into the 3.4 branch instead (closes #32870).

Discussion
----------

| Q             | A
| ------------- | ---
| Branch?     | 4.3
| Bug fix?      | yes
| New feature?  | no
| Tests pass?   | yes
| Fixed tickets | #32853
| License       | MIT

Commits
-------

7cf9ed6 #32853 Check if $this->parameters is array.
@ABGEO ABGEO deleted the 32853-undefined-env-issue branch August 3, 2019 18:26
This was referenced Aug 26, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ABGEO @nicolas-grekas @xabbuh @carsonbot