[Yaml] fix comment in multi line value #32767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soufianZantar
force-pushed
the
fix/yml-coments
branch
from
61130c4
to
0fb6052
Compare
xabbuh
requested changes
Jul 27, 2019
soufianZantar
force-pushed
the
fix/yml-coments
branch
from
0fb6052
to
2dd081a
Compare
Also 4.3 is affected, i think this should merged into 4.3 and 3.4. Multi-line strings support will be removed in 4.4 and 5.0 versions, right? |
seriquynh
approved these changes
Jul 27, 2019
xabbuh
requested changes
Jul 29, 2019
There was a problem hiding this comment.
@soufianZantar I have rebased your PR on the 3.4 branch. There's only one minor thing left to do. After that the PR is ready to be merged. Thanks for your work on this.
soufianZantar
force-pushed
the
fix/yml-coments
branch
from
1213324
to
dd945e3
Compare
xabbuh
approved these changes
Jul 30, 2019
nicolas-grekas
changed the title
|
Thank you @soufianZantar. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 30, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Yaml] fix comment in multi line value | Q | A | ------------- | --- | Branch? | 4.3 and lower <!-- see below --> | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32667 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Comments after blank lines are read as value in yaml. ``` `$yaml = <<<YAML parameters: abc # Comment YAML; var_dump(Symfony\Component\Yaml\Yaml::parse($yaml));` ``` **Result before fix:** ``` array(1) { ["parameters"]=> string(13) "abc # Comment" } ``` **Result after fix:** ``` array(1) { ["parameters"]=> string(3) "abc" } ``` Commits ------- dd945e3 fix(yml): fix comment in milti line value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments after blank lines are read as value in yaml.
Result before fix:
Result after fix: