Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] make tests forward compatible with DI 4.4 #32724

Merged
merged 1 commit into from Jul 24, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 24, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh
Copy link
Member Author

xabbuh commented Jul 24, 2019

This is necessary to adapt for the changes made in #32332 (we did similar changes in #32615 for the 3.4 branch).

@xabbuh xabbuh changed the base branch from 4.3 to 3.4 July 24, 2019 17:00
@xabbuh xabbuh modified the milestones: 4.3, 3.4 Jul 24, 2019
@xabbuh
Copy link
Member Author

xabbuh commented Jul 24, 2019

rebased onto 3.4 after talking with @nicolas-grekas to mitigate the potential for conflicts when merging branches up

@xabbuh xabbuh merged commit affede1 into symfony:3.4 Jul 24, 2019
xabbuh added a commit that referenced this pull request Jul 24, 2019
…4.4 (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] make tests forward compatible with DI 4.4

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

affede1 make tests forward compatible with DI 4.4
@xabbuh xabbuh deleted the pr-32332 branch July 24, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants