Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebProfileBundle] Avoid getting right to left style #32644

Merged
merged 1 commit into from Jul 24, 2019
Merged

[WebProfileBundle] Avoid getting right to left style #32644

merged 1 commit into from Jul 24, 2019

Conversation

Arman-Hosseini
Copy link
Contributor

Q A
Branch? >= 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

@Arman-Hosseini Arman-Hosseini changed the title Avoid getting right to left style [WebProfileBundle] Avoid getting right to left style Jul 21, 2019
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 21, 2019
@fabpot
Copy link
Member

fabpot commented Jul 23, 2019

IIRC, I think that the web profiler was compatible with right to left. Isn't the case anymore?

@Arman-Hosseini
Copy link
Contributor Author

Hello @fabpot .
Thanks for reviewing.

It should not follow the right-to-left style because it's not interesting to display it.
It's best to stay with left-to-right.

@derrabus
Copy link
Member

Your screenshot looks like the default page should be fixed as well. 👀

fabpot
fabpot approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it now!

@fabpot
Copy link
Member

fabpot commented Jul 24, 2019

Thank you @Arman-Hosseini.

@fabpot fabpot merged commit 162819f into symfony:3.4 Jul 24, 2019
fabpot added a commit that referenced this pull request Jul 24, 2019
@fabpot
bug #32644 [WebProfileBundle] Avoid getting right to left style (Arma…
3f652f1 
…n-Hosseini)

This PR was merged into the 3.4 branch.

Discussion
----------

[WebProfileBundle] Avoid getting right to left style

| Q             | A
| ------------- | ---
| Branch?       | >= 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

162819f Avoid getting right to left style
@Arman-Hosseini Arman-Hosseini deleted the patch-6 branch July 24, 2019 10:41
This was referenced Jul 27, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Arman-Hosseini @fabpot @derrabus @nicolas-grekas @carsonbot