Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum version of symfony/phpunit-bridge #32572

Merged
merged 1 commit into from Jul 18, 2019

Conversation

fancyweb
Copy link
Contributor

@fancyweb fancyweb commented Jul 17, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Before those versions, PHPUnit was downloaded directly on github (on https://github.com/sebastianbergmann/phpunit/archive/$PHPUNIT_VERSION.zip), not installed with composer.

However, this behavior is not working (anymore ?) because https://github.com/sebastianbergmann/phpunit/archive/6.5.zip is a 404 (Warning: fopen(https://github.com/sebastianbergmann/phpunit/archive/6.5.zip): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found).

When installing lowest dependencies to run tests in local, you encounter this problem and you cannot launch the tests unless you set the SYMFONY_PHPUNIT_VERSION to 6.5.14. But IMHO, it should work by default.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 17, 2019
@derrabus
Copy link
Member

However, this behavior is not working (anymore ?)

Yes, because the old release branches are gone.

@fabpot
Copy link
Member

fabpot commented Jul 18, 2019

Thank you @fancyweb.

@fabpot fabpot merged commit 04e0f3c into symfony:3.4 Jul 18, 2019
fabpot added a commit that referenced this pull request Jul 18, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Bump minimum version of symfony/phpunit-bridge

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Before those versions, PHPUnit was downloaded directly on github (on `https://github.com/sebastianbergmann/phpunit/archive/$PHPUNIT_VERSION.zip`), not installed with composer.

However, this behavior is not working (anymore ?) because https://github.com/sebastianbergmann/phpunit/archive/6.5.zip is a 404 (`Warning: fopen(https://github.com/sebastianbergmann/phpunit/archive/6.5.zip): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found`).

When installing lowest dependencies to run tests in local, you encounter this problem and you cannot launch the tests unless you set the `SYMFONY_PHPUNIT_VERSION` to `6.5.14`. But IMHO, it should work by default.

Commits
-------

04e0f3c Bump minimum version of symfony/phpunit-bridge
@fancyweb fancyweb deleted the bump-min-required-phpunit-bridge branch July 18, 2019 08:08
This was referenced Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants