[Serializer] XmlEncoder: don't cast padded strings #32438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 17, 2019
fabpot
approved these changes
Jul 18, 2019
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jul 18, 2019
…agi) This PR was merged into the 3.4 branch. Discussion ---------- [Serializer] XmlEncoder: don't cast padded strings | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #23122 (comment) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A This was a suggestion of @nicolas-grekas in #23122. Which seems to have been forgotten. But shouldn't we also avoid casting something like `.18`, `+18`, `-18`? Commits ------- c1bfaa1 [Serializer] XmlEncoder: don't cast padded strings
This was referenced Jul 27, 2019
Merged
Merged
Merged
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a suggestion of @nicolas-grekas in #23122. Which seems to have been forgotten.
But shouldn't we also avoid casting something like
.18,+18,-18?