Catch JsonException and rethrow in JsonEncode #32206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #31860 provided handling of PHP 7.3
JSON_THROW_ON_ERROR
behavior in the variousJsonEncode
and related classes/methods.PR #31869 adjusted that. In particular, it adjusted
src/Symfony/Component/Serializer/Encoder/JsonDecode.php
so that it catches anyJsonException
and re-throws it asNotEncodableValueException
. That preserves the previous behavior ofJsonDecode:decode
- it always throwsNotEncodableValueException
when something goes wrong.IMO
JsonEncode:encode
needs the same logic. At the moment, if a caller specifiesJSON_THROW_ON_ERROR
then the method can throwJsonException
, but actually the "standard" forJsonEncode:encode
is that it throwsNotEncodableValueException
Adjust
JsonEncode:encode
to catchJsonException
and rethrow it asNotEncodableValueException