Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Fix calling Client::getProfile() before sending a request #32173

Merged
merged 1 commit into from Jun 26, 2019

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jun 25, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Prevent throwing an error when calling getProfile before a request has been sent.

@dunglas dunglas changed the title [FrameworkBundle] Fix calling Client::getProfile() before sending a r… [FrameworkBundle] Fix calling Client::getProfile() before sending a request Jun 25, 2019
@fabpot
Copy link
Member

fabpot commented Jun 26, 2019

Thank you @dunglas.

@fabpot fabpot merged commit 9e6f4b2 into symfony:3.4 Jun 26, 2019
fabpot added a commit that referenced this pull request Jun 26, 2019
…sending a request (dunglas)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Fix calling Client::getProfile() before sending a request

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Prevent throwing an error when calling getProfile before a request has been sent.

Commits
-------

9e6f4b2 [FrameworkBundle] Fix calling Client::getProfile() before sending a request
This was referenced Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants