[HttpFoundation] fix accessing session bags #32137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 22, 2019
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #30682 |
| License | MIT |
| Doc PR |
Tobion
reviewed
Jun 22, 2019
| return $this->storage->getBag($name)->getBag(); | ||
| $bag = $this->storage->getBag($name); | ||
|
|
||
| return method_exists($bag, 'getBag') ? $bag->getBag() : $bag; |
There was a problem hiding this comment.
Why not test against SessionBagProxy to make the intention clear?
There was a problem hiding this comment.
Agree, otherwise i'd prefer to deprecate the situation (calling getBag on a non-proxy bag).
But i tend to believe one relies on a bug in this case.
There was a problem hiding this comment.
I don't know how many people out there created their own SessionBagInterface implementations and also implemented this method this method to work around this issue. IMO we should play safe here to not risk any existing application.
fabpot
approved these changes
Jun 26, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 26, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] fix accessing session bags | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30682 | License | MIT | Doc PR | Commits ------- 7a4570d fix accessing session bags
This was referenced Jun 26, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.