Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] tag the FileType service as a form type #32116

Merged
merged 1 commit into from Jun 20, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 20, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets part of #32045
License MIT
Doc PR

In #30961 we undeprecated the form.type.file service as we need to pass the translator to the form type. But we forgot to add back the form.type tag which means that the form registry actually never used our service but instantiated the FileType itself and thus the type was never able to use a translator.

@fabpot
Copy link
Member

fabpot commented Jun 20, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit ea5b1f4 into symfony:3.4 Jun 20, 2019
fabpot added a commit that referenced this pull request Jun 20, 2019
…(xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] tag the FileType service as a form type

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | part of #32045
| License       | MIT
| Doc PR        |

In #30961 we undeprecated the `form.type.file` service as we need to pass the translator to the form type. But we forgot to add back the `form.type` tag which means that the form registry actually never used our service but instantiated the `FileType` itself and thus the type was never able to use a translator.

Commits
-------

ea5b1f4 tag the FileType service as a form type
@xabbuh xabbuh deleted the issue-32045 branch June 20, 2019 11:26
This was referenced Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants