[Form] Double file size validation when file is beyond the 'upload_max_filesize' parameter

[COil]

Symfony version(s) affected: 4.3.1

Description
I have a double file size validation when file is beyond the 'upload_max_filesize' parameter.
In this case the max size is set to 500ko in the form and the max size allowed by php 2mo. Additionally the error message isn't translated.

How to reproduce

/**
 * Add or edit the avatar.
 */
class AvatarFormType extends AbstractType
{
    private const IMAGE_MAX_SIZE = 512000;  
    public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder->add('avatar', FileType::class, [
            'required' => true,
            'constraints' => [
                new NotBlank(),
                new Image([
                    'maxSize' => self::IMAGE_MAX_SIZE,
                ]),
            ],
        ]);
    }
}

and php setting :
upload_max_filesize | 2M | 2M

Possible Solution
Detect if a maxSize constraint already exists and is below the upload_max_filesize value?

See you. COil.

[xabbuh]

The fact that the message is not translated looks like a bug to me. Can you check in the profiler if it reports any missing translation?

Though I wonder why the size constraint is triggered at all. If the file cannot be uploaded, this shouldn't happen.

[COil]

Hi Xabbuh, well it's weird, look at this, in the validator panel I can only see my constraint :

But in the form panel, I can see the second message but there isn't constraint violation associated to it (at least in the debug panel)

There isn't i18n warning in the debug bar regarding the message.

[xabbuh]

That the filesize check is not listed in the validator panel is expected as that error is caught on the form level and attached as an error to the form without using the validator component.

I am not sure how we would solve the Image constraint validation though. We could skip validation if the file is an UploadedFile instance whose error is not 0. However, that would require hardcoding knowledge about the HttpFoundation in the validator component.

[COil]

hi Xabbuh. So, what's your suggestion? I can try to debug this tomorrow.

Why FileType doesn't use the public constants of File for translations?

How to pass the translator object to the file type? The translator object is null, that's why the message isn't translated.

Someone had the same the same problem :

• https://stackoverflow.com/q/56463087/633864

[xabbuh]

@COil I found out why the translation didn't happen (see #32116).

Though I have no idea yet how to prevent the double error message.

[COil]

@xabbuh there is also an error in the translation domain :

Should be :

$message = $this->translator->trans($messageTemplate, $messageParameters, 'validators');

in FileType.php.

I have tested and it works now with this last fix.

[o-alquimista]

@COil Did you find a workaround for the duplicated error message? I can reproduce this.

[COil]

No. :) As it's not critical. But may be you can change the 'upload_max_filesize' on the fly just for the action.

[COil]

Just a comment, obviously we can't change the upload_max_filesize ini setting at runtime so this trick will not function.

[lugosium]

Hello,

Got duplicate error message too.

This is confusing for the user i think, If i limit the image to 2mo, users does not have to know my upload_max_filesize value.

The only case is when the upload_max_filesize value is lower than maxSize.

[xabbuh]

Can you please check if #39119 fixes this?