[Form] validate composite constraints in all groups #32037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 14, 2019
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #31990 |
| License | MIT |
| Doc PR |
xabbuh
commented
Jun 14, 2019
| @@ -90,7 +91,9 @@ public function validate($form, Constraint $formConstraint) | |||
| $validator->atPath('data')->validate($form->getData(), $constraint, $group); | |||
|
|
|||
| // Prevent duplicate validation | |||
| continue 2; | |||
| if (!$constraint instanceof Composite) { | |||
There was a problem hiding this comment.
This is basically the same fix we already applied in the Validator component last year in #29499.
fabpot
approved these changes
Jun 14, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form] validate composite constraints in all groups | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31990 | License | MIT | Doc PR | Commits ------- 94ded00 validate composite constraints in all groups
This was referenced Jun 26, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.