[Routing] fix absolute url generation when scheme is not known #32000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
commented
Jun 12, 2019
| } | ||
|
|
||
| public function testDefaultHostIsUsedWhenContextHostIsEmptyAndSchemeIsNot() |
There was a problem hiding this comment.
that test was the same as the one above because a RequestContext has a default scheme. I changed it slightly to handle a different case.
Tobion
force-pushed
the
url-generator-wihout-scheme
branch
from
4fc4817
to
8e04222
Compare
nicolas-grekas
approved these changes
Jun 12, 2019
fabpot
approved these changes
Jun 13, 2019
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Jun 13, 2019
…nown (Tobion) This PR was merged into the 3.4 branch. Discussion ---------- [Routing] fix absolute url generation when scheme is not known | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #25491 | License | MIT | Doc PR | This fixes two edge cases in the url generator: 1. when the context scheme is not known (empty) generating an absolute url would return an invalid url starting with `://host/path`. #25491 handled the case when the host is unknown which makes sense. but the way it was done, created this new problem. 2. non-http(s) urls do not require a host. e.g. typical `file:///path` urls. url generator is fixed to be in line with rfc3986 Commits ------- 8e04222 [Routing] fix absolute url generation when scheme is not known
This was referenced Jun 26, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two edge cases in the url generator:
://host/path. [Routing] Use the default host even if context is empty #25491 handled the case when the host is unknown which makes sense. but the way it was done, created this new problem.file:///pathurls. url generator is fixed to be in line with rfc3986