[Process] Fix infinite waiting for stopped process #31568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 22, 2019
Simperfit
approved these changes
May 22, 2019
|
Thank you @mshavliuk. |
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2019
…iuk) This PR was squashed before being merged into the 3.4 branch (closes #31568). Discussion ---------- [Process] Fix infinite waiting for stopped process | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31548 | License | MIT ### Description Add a regression test `Symfony\Component\Process\Tests\ProcessTest:testWaitStoppedDeadProcess` to reproduce the related bug #31548 . It consists of one file `ErrorProcessInitiator.php`, which executes as another process because otherwise if `Process::wait()` goes in an infinite loop (which is test checks) it will be impossible to handle it and stop test correctly. The second commit contains bug fix, which is only `$this->checkTimeout();` call, that prevents infinite loop. Commits ------- 6b9ee1e [Process] Fix infinite waiting for stopped process
This was referenced May 28, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a regression test
Symfony\Component\Process\Tests\ProcessTest:testWaitStoppedDeadProcessto reproduce the related bug #31548 . It consists of one fileErrorProcessInitiator.php, which executes as another process because otherwise ifProcess::wait()goes in an infinite loop (which is test checks) it will be impossible to handle it and stop test correctly.The second commit contains bug fix, which is only
$this->checkTimeout();call, that prevents infinite loop.