[Serializer] Fix denormalization of object with variadic constructor typed argument

[ajgarlag]

Q	A
Branch?	3.4 up to 4.2
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#31436
License	MIT

This PR adds a test to demonstrate the bug, and a fix to squash it.

[ajgarlag]

PR ready to merge

[dunglas]

Why this change?

[ajgarlag]

Without this change, when using the PropertyNormalizer, the deserialized object is successfully instantiated, but the property is overwritten again with the original $data[$key] array value ignoring the type hint.

https://github.com/ajgarlag/symfony/blob/a736781cc2499a3ab829ddbf7898740e1638d128/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.php#L147-L150

[nicolas-grekas]

Thank you @ajgarlag.

[ajgarlag]

@nicolas-grekas I'd like to have this issue fixed in 4.2 branch too. Can you tell me when will be merged into that branch? Thanks.

[nicolas-grekas]

There is nothing to do on your side, we will merge 3.4 into 4.2 with the fix.

[WalentinG]

@nicolas-grekas, the fix breaks current workaround
try the dummy object below in your test, with

$extractor = new PropertyInfoExtractor([], [new PhpDocExtractor(), new ReflectionExtractor()]);
$normalizer = new PropertyNormalizer(null, null, $extractor);

<?php

namespace Symfony\Component\Serializer\Tests\Fixtures;

final class VariadicConstructorAnnotationTypedArgsDummy
{
    /** @var Dummy[] */
    private $foo;
    
    public function __construct(...$foo)
    {
        $this->foo = $foo;
    }
    
    public function getFoo()
    {
        return $this->foo;
    }
}