Reword VarDumper description #31339
Merged
Reword VarDumper description #31339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoBakx
reviewed
May 1, 2019
| @@ -2,8 +2,8 @@ VarDumper Component | |||
| =================== | |||
|
|
|||
| The VarDumper component provides mechanisms for walking through any arbitrary | |||
| PHP variable. Built on top, it provides a better `dump()` function that you | |||
| can use instead of `var_dump`. | |||
| PHP variable. It also provides a better `dump()` function that you can use | |||
There was a problem hiding this comment.
I think it would work better without "also".
|
Linking to Slack is like linking to an oral discussion: it will disappear from memories quite soon and won't allow others to get the arguments soon too. |
greg0ire
force-pushed
the
var-dumper-description-wording
branch
from
3413560
to
6c44f08
Compare
I changed the base. I assumed pedantic changes that are not bugfixes should go on master :P |
It was provided as a bonus, I replaced it with an anonymized screenshot. |
It is hard to understand what "Built on top" refers to, and even when knowing, the sentence looks weird.
greg0ire
force-pushed
the
var-dumper-description-wording
branch
from
6c44f08
to
6024e16
Compare
OskarStark
approved these changes
May 1, 2019
TimoBakx
approved these changes
May 1, 2019
fabpot
approved these changes
May 1, 2019
|
Thank you @greg0ire. |
fabpot
added a commit
that referenced
this pull request
May 1, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Reword VarDumper description | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a It is hard to understand what "Built on top" refers to, and even when knowing, the sentence looks weird.  The description of [the Github repository](https://github.com/symfony/var-dumper) has the same issue and should be changed. Commits ------- 6024e16 Reword VarDumper description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is hard to understand what "Built on top" refers to, and even when
knowing, the sentence looks weird.
The description of the Github repository has the same issue and should be changed.