[Workflow] Fixed dumping when many transition with same name exist

[lyrixx]

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no>
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

---

With this configuration:

framework:
    workflows:
        foobar:
            type: workflow
            supports:
                - stdClass
            initial_place: a
            places:
                - a
                - b
                - c
                - cancelled
            transitions:
                -   name: a-b
                    from: a
                    to: b
                -   name: b-c
                    from: b
                    to: c
                -   name: cancel
                    from: a
                    to: cancelled
                -   name: cancel
                    from: b
                    to: cancelled
                -   name: cancel
                    from: c
                    to: cancelled

before:

After:

[lyrixx]

Failure are not related

[fabpot]

Thank you @lyrixx.

[fabpot]

@lyrixx We could remove the call to dotize here as $i is always an integer, right?

[fabpot]

Nevermind, in 4.2, we are using a hash, so a string (so I'm going to change %d to %s in 4.2).

[ruudk]

Is this actually what you want? Because this makes large workflows very messy. Why not merge the transitions and show them with 1 arrow like this:

This can be achieved easily with this change:

 protected function findEdges(Definition $definition)
 {
     $dotEdges = [];
 
     foreach ($definition->getTransitions() as $i => $transition) {
         foreach ($transition->getFroms() as $from) {
-            $dotEdges[] = [
+            $dotEdges[$from.$transition->getName().'from'] = [
                 'from' => $from,
                 'to' => $transition->getName(),
                 'direction' => 'from',
                 'transition_number' => $i,
             ];
         }
         foreach ($transition->getTos() as $to) {
-            $dotEdges[] = [
+            $dotEdges[$transition->getName().$to.'to'] = [
                 'from' => $transition->getName(),
                 'to' => $to,
                 'direction' => 'to',
                 'transition_number' => $i,
             ];
         }
     }
 
     return $dotEdges;
 }

[lyrixx]

@ruudk Because this graph is not accurate. According to this representation the cancel transition is enabled if and only if there is a token in (all) places a, b, and c. But, according to the definition, there are 3 cancel transition one from a, one from b, and one from c.

I hope it's more clear :)