[HttpKernel] Fixed LoggerDataCollector crashing on empty file #31076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
althaus
changed the title
nicolas-grekas
approved these changes
Apr 11, 2019
nicolas-grekas
force-pushed
the
31050-fix-logger-data-collector
branch
from
9fded1f
to
291c73a
Compare
|
Thank you @althaus. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 11, 2019
…ile (althaus) This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #31076). Discussion ---------- [HttpKernel] Fixed LoggerDataCollector crashing on empty file | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31050 | License | MIT This PR adds a check to the LoggerDataCollector if there's acutal some content in the log file. Commits ------- 291c73a Catch empty deprecation.log silently (fixes #31050)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the LoggerDataCollector if there's acutal some content in the log file.