Show more accurate message in profiler when missing stopwatch #31059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Apr 10, 2019
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
Outdated
Show resolved
Hide resolved
dbrumann
approved these changes
Apr 10, 2019
stof
approved these changes
Apr 10, 2019
javiereguiluz
approved these changes
Apr 10, 2019
xabbuh
approved these changes
Apr 10, 2019
fabpot
approved these changes
Apr 10, 2019
fabpot
force-pushed
the
fix/missing-stopwatch-message
branch
from
3e949d4
to
326aa86
Compare
|
Thank you @linaori. |
fabpot
added a commit
that referenced
this pull request
Apr 10, 2019
…tch (linaori) This PR was squashed before being merged into the 3.4 branch (closes #31059). Discussion ---------- Show more accurate message in profiler when missing stopwatch | Q | A | ------------- | --- | Branch? | 3.4+ | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31056 | License | MIT | Doc PR | ~ This adds a message to the profiler if the stopwatch component is not installed, instead of suggesting to check if debug is enabled (even if it is enabled). I had to add a method in the collector to expose the value collected, which in theory adds a feature. Is there perhaps a way to expose this collected data _without_ a "BC break"? I don't think it breaks anything, though it does make the dependencies on the http-kernel a bit strict. The other solution is to ignore if it's null and only act if it's a boolean (feature detection). Commits ------- 326aa86 Show more accurate message in profiler when missing stopwatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a message to the profiler if the stopwatch component is not installed, instead of suggesting to check if debug is enabled (even if it is enabled).
I had to add a method in the collector to expose the value collected, which in theory adds a feature. Is there perhaps a way to expose this collected data without a "BC break"? I don't think it breaks anything, though it does make the dependencies on the http-kernel a bit strict. The other solution is to ignore if it's null and only act if it's a boolean (feature detection).