[Console] Fix stty not reset when aborting in QuestionHelper::autocomplete() #30883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Simperfit
commented
Apr 6, 2019
Simperfit
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #30861 |
| License | MIT |
| Doc PR | none |
Simperfit
force-pushed
the
bugfix/terminal-state-is-wrong-after-running-test
branch
from
fbb9df8
to
c9bec88
Compare
chalasr
changed the title
Simperfit
force-pushed
the
bugfix/terminal-state-is-wrong-after-running-test
branch
from
c9bec88
to
485d2bb
Compare
Simperfit
force-pushed
the
bugfix/terminal-state-is-wrong-after-running-test
branch
from
485d2bb
to
f54389b
Compare
chalasr
approved these changes
Apr 6, 2019
fabpot
approved these changes
Apr 6, 2019
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…er::autocomplete() (Simperfit) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Fix stty not reset when aborting in QuestionHelper::autocomplete() | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #30861 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- f54389b bugfix: the terminal state was wrong and not reseted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.