[Form] Php doc fixes and cs + optimizations #30879
Merged
+370
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Apr 6, 2019
sstok
reviewed
Apr 6, 2019
dbrumann
reviewed
Apr 6, 2019
dmaicher
reviewed
Apr 6, 2019
src/Symfony/Component/Form/Form.php
Outdated
| } | ||
|
|
||
| if (null === $this->getName() || '' === $this->getName()) { | ||
| if (!$this->name) { |
There was a problem hiding this comment.
what if the name is '0'? 😄 Can it happen?
There was a problem hiding this comment.
Yes it can, nice catch!
There was a problem hiding this comment.
Shall we add a testcase or is there already one?
There was a problem hiding this comment.
Ok so I would just write if (trim($this->name) === '')
As discussed let's avoid the function call 😄
There was a problem hiding this comment.
No function call :)
dbrumann
reviewed
Apr 6, 2019
|
Thanks for the reviews :). Comments addressed, ready for another round! |
Simperfit
approved these changes
Apr 6, 2019
stof
approved these changes
Apr 6, 2019
vudaltsov
approved these changes
Apr 6, 2019
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form] Php doc fixes and cs + optimizations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | ~ | License | MIT | Doc PR | ~ <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Some micro optimizations may target master with some profiling but I would like some reviews first. Thanks! Commits ------- 56429a6 [Form] various minor fixes
Merged
xabbuh
added a commit
that referenced
this pull request
Apr 6, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form] fix tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30879 | License | MIT | Doc PR | Commits ------- 83c661d fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some micro optimizations may target master with some profiling but I would like some reviews first. Thanks!