Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Added check of constuctor modifiers to AbstractNormalizer #30749

Merged
merged 1 commit into from Mar 30, 2019

Conversation

NekaKawaii
Copy link
Contributor

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30748
License MIT

If constructor is not public, instantiate target object without constructor to prevent errors like Access to non-public constructor of class Target

@fabpot fabpot changed the base branch from 4.2 to 3.4 March 30, 2019 07:26
@fabpot
Copy link
Member

fabpot commented Mar 30, 2019

Thank you @NekaKawaii.

@fabpot fabpot merged commit eb0e14c into symfony:3.4 Mar 30, 2019
fabpot added a commit that referenced this pull request Mar 30, 2019
…ctNormalizer (NekaKawaii)

This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #30749).

Discussion
----------

[Serializer] Added check of constuctor modifiers to AbstractNormalizer

| Q             | A
| ------------- | ---
| Branch?       |  4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30748
| License       | MIT

If constructor is not public, instantiate target object without constructor to prevent errors like `Access to non-public constructor of class Target`

Commits
-------

eb0e14c [Serializer] Added check of constuctor modifiers to AbstractNormalizer
@xabbuh xabbuh added this to the 3.4 milestone Apr 1, 2019
This was referenced Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants