[Validator] Improve constraint default option check #30737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vudaltsov
changed the title
fabpot
added a commit
that referenced
this pull request
Mar 29, 2019
…(vudaltsov) This PR was squashed before being merged into the 3.4 branch (closes #30736). Discussion ---------- [Validator] Fix annotation default for @count and @Length | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | is it worth mentioning? `Count` and `Length` constraints allow to pass the exact value as the constructor argument when used in code. ```php new Length(5); // is same as new Length(['min' => 5, 'max' => 5]); ``` At the same time when using them as annotations, `@Assert\Length(5)` throws `The options "" do not exist in constraint Symfony\\Component\\Validator\\Constraints\\Length` (fix for ugly exception is proposed in #30737). This happens because annotation's default value is passed as `value`. Since `Length` does not have a default option, `value` is replaced with `''`. This PR fixes this inconsistency. Commits ------- 7bfb8c1 [Validator] Fix annotation default for @count and @Length
|
@fabpot , done. Also fixed other messages in the |
fabpot
force-pushed
the
constraint-annotation-undefined-default-option
branch
from
b04345d
to
915912e
Compare
|
Thank you @vudaltsov. |
fabpot
added a commit
that referenced
this pull request
Mar 29, 2019
…tsov) This PR was squashed before being merged into the 3.4 branch (closes #30737). Discussion ---------- [Validator] Improve constraint default option check | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Any constraint without default option used as annotation with unnamed first argument (for example, `@Assert\Collection(1)`) throws an exception with an ugly message `The options "" do not exist in constraint Collection`. This PR makes constraint check the default option in the annotation case in the same way it checks it in the "real" code case. So the exception will be `No default option is configured for constraint Collection.` Commits ------- 915912e [Validator] Improve constraint default option check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any constraint without default option used as annotation with unnamed first argument (for example,
@Assert\Collection(1)) throws an exception with an ugly messageThe options "" do not exist in constraint Collection.This PR makes constraint check the default option in the annotation case in the same way it checks it in the "real" code case. So the exception will be
No default option is configured for constraint Collection.