Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes" #30720

Merged
merged 1 commit into from Mar 30, 2019

Conversation

eborges78
Copy link

…ed in "ignored_attributes"

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30453
License MIT

The GetSetMethodNormalizer class correctly ignores the attributes specified in "ignored_attributes"

@nicolas-grekas nicolas-grekas changed the title Fix getSetMethodNormalizer to correctly ignore the attributes specifi… Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes" Mar 30, 2019
@fabpot
Copy link
Member

fabpot commented Mar 30, 2019

Thank you @eborges78.

@fabpot fabpot merged commit 606d8d3 into symfony:3.4 Mar 30, 2019
fabpot added a commit that referenced this pull request Mar 30, 2019
…tes specified in "ignored_attributes" (Emmanuel BORGES)

This PR was merged into the 3.4 branch.

Discussion
----------

Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes"

…ed in "ignored_attributes"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30453
| License       | MIT

The GetSetMethodNormalizer class correctly ignores the attributes specified in "ignored_attributes"

Commits
-------

606d8d3 Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes"
This was referenced Apr 2, 2019
sandergo90 pushed a commit to sandergo90/symfony that referenced this pull request Jul 4, 2019
…attributes specified in "ignored_attributes" (Emmanuel BORGES)

This PR was merged into the 3.4 branch.

Discussion
----------

Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes"

…ed in "ignored_attributes"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#30453
| License       | MIT

The GetSetMethodNormalizer class correctly ignores the attributes specified in "ignored_attributes"

Commits
-------

606d8d3 Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants