[Bridge][Twig] DebugCommand - fix escaping and filter #30660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Mar 31, 2019
fabpot
force-pushed
the
3_4_Twig_DebugCommand.php
branch
from
80818ef
to
7bdb066
Compare
|
Thank you @SpacePossum. |
fabpot
added a commit
that referenced
this pull request
Mar 31, 2019
…cePossum) This PR was squashed before being merged into the 3.4 branch (closes #30660). Discussion ---------- [Bridge][Twig] DebugCommand - fix escaping and filter | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT The PR fixes: - output escaping was not done for decorated consoles - filter was not applied when using format json + added some tests for paths currently not tested Commits ------- 7bdb066 [Bridge][Twig] DebugCommand - fix escaping and filter
|
@SpacePossum I did not merge your patch on the bridge in 4.2 because I couldn't figure out how to resolve merge conflicts. Could you please send a PR against 4.2? |
|
sure thing @nicolas-grekas , please see #30811 |
fabpot
added a commit
that referenced
this pull request
Apr 1, 2019
…pacePossum) This PR was merged into the 4.2 branch. Discussion ---------- [Bridge][Twig] DebugCommand - fix escaping and filter | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT cherry-pick on 4.2, conflicts resolved, original PR #30660 (comment) Commits ------- b7120c5 [Bridge][Twig] DebugCommand - fix escaping and filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes: