Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translation] Update defaut format from yml to yaml #30498

Merged
merged 1 commit into from Mar 9, 2019

Conversation

GaryPEGEOT
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30443
License MIT
Doc PR

As stated in #30443 , command php bin/console translation:update --dump-messages --force fr will by default output the translation to yml format, which is not supported by Symfony

@GaryPEGEOT GaryPEGEOT changed the title Update defaut format from yml to yaml [translation] Update defaut format from yml to yaml Mar 9, 2019
@fabpot
Copy link
Member

fabpot commented Mar 9, 2019

Thank you @GaryPEGEOT.

@fabpot fabpot merged commit ba42030 into symfony:3.4 Mar 9, 2019
fabpot added a commit that referenced this pull request Mar 9, 2019
…EGEOT)

This PR was squashed before being merged into the 3.4 branch (closes #30498).

Discussion
----------

[translation] Update defaut format from yml to yaml

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30443
| License       | MIT
| Doc PR        |

As stated in #30443 , command `php bin/console translation:update --dump-messages --force fr` will by default output the translation to yml format, which is not supported by Symfony

Commits
-------

ba42030 [translation] Update defaut format from yml to yaml
@GaryPEGEOT GaryPEGEOT deleted the patch-2 branch March 9, 2019 21:54
This was referenced Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants