Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConstraintValidatorTestCase not compatible with PHPUnit 8 #30476

Closed
julien-maurel opened this issue Mar 7, 2019 · 2 comments
Closed

ConstraintValidatorTestCase not compatible with PHPUnit 8 #30476

julien-maurel opened this issue Mar 7, 2019 · 2 comments
Labels
Validator

Comments

@julien-maurel
Copy link

Symfony version(s) affected: 4.2.4

Description
Class Symfony\Component\Validator\Test\ConstraintValidatorTestCase is not compatble with PHPUnit8 because setup and teardown methods have no return type hint

Possible Solution
Just add void return type hint on these methods
@xabbuh
Copy link
Member

xabbuh commented Mar 7, 2019

see #30474

@xabbuh
Copy link
Member

xabbuh commented May 29, 2020

closing here as #30474 was merged a while back

@xabbuh xabbuh closed this as completed May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xabbuh @julien-maurel