compatibility with phpunit8 #30474
Merged
compatibility with phpunit8 #30474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about a generic trait that would call a private |
You mean a single trait with all methods for the 3 classes? |
|
yes, and keep the code in the current classes |
|
Well, it makes sense. |
garak
force-pushed
the
phpunit8-compat-test
branch
from
300289d
to
a045ef0
Compare
|
🤔 3 proposals: one trait per component, add the trait in the bridge, add the trait in contracts. Pick one :) |
|
Better now? Let me know, I'll squash |
|
Looks like we're converging on something nice :) |
src/Symfony/Component/Form/Test/FormIntegrationTestCaseSetupTrait.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Mar 7, 2019
garak
force-pushed
the
phpunit8-compat-test
branch
from
c7c4ca1
to
5ef254f
Compare
xabbuh
reviewed
Mar 8, 2019
xabbuh
approved these changes
Mar 8, 2019
|
Thank you @garak. |
fabpot
added a commit
that referenced
this pull request
Mar 9, 2019
This PR was merged into the 3.4 branch. Discussion ---------- compatibility with phpunit8 This basically adds the same phpunit8 compatibility layer added in #30084 (but for other test classes) See also discussion in #30071 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30071 | License | MIT | Doc PR | none Commits ------- 5ef254f compatibility with phpunit8
fabpot
added a commit
that referenced
this pull request
Mar 19, 2019
…Dude) This PR was merged into the 3.4 branch. Discussion ---------- [Tests] fixed compatbility of assertEquals(): void | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Same as #30474. Commits ------- 3f7bedc [Tests] fixed compatbility of assertEquals(): void
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically adds the same phpunit8 compatibility layer added in #30084 (but for other test classes)
See also discussion in #30071