Fix getItems() performance issue with RedisCluster (php-redis) #30351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On any kind of multi loads, including tags loading, current code leads to an explosion of Redis lookups slowing down performance. This backports the code for mget() usage from 4.x in order to fix it. It's done with one small improvment which would also be relevant for 4.x, only using pipeline on cluster on predis as mget is more efficient.
nicolas-grekas
approved these changes
Feb 23, 2019
fabpot
approved these changes
Feb 23, 2019
|
Thank you @andrerom. |
fabpot
added a commit
that referenced
this pull request
Feb 23, 2019
…dis) (andrerom) This PR was merged into the 3.4 branch. Discussion ---------- Fix getItems() performance issue with RedisCluster (php-redis) | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | TBD | License | MIT On any kind of multi loads, including tags loading where it's always the case, current code leads to an explosion of Redis lookups affecting performance on RedisCluster _(as it does not support pipeline)_. This backports the code for mget() usage from 4.x in order to fix it. It's done with one small improvment which would also be relevant for 4.x, only using pipeline on cluster on predis as mget is more efficient (ref redis doc). Commits ------- 178506e Fix getItems() performance issue with RedisCluster (php-redis)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On any kind of multi loads, including tags loading where it's always the case, current code leads to an explosion of Redis lookups affecting performance on RedisCluster (as it does not support pipeline).
This backports the code for mget() usage from 4.x in order to fix it.
It's done with one small improvment which would also be relevant for 4.x, only using pipeline on cluster on predis as mget is more efficient (ref redis doc).