[Security] Change FormAuthenticator if condition #30347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just discovered I need to write some additional tests. |
xabbuh
reviewed
Feb 22, 2019
src/Symfony/Component/Security/Http/Firewall/SimpleFormAuthenticationListener.php
Outdated
Show resolved
Hide resolved
|
I changed the if condition and added some test cases to test additional scenarios. I hope it's no problem I added a class in the test file. This allowed me to test if the |
OskarStark
requested changes
Feb 22, 2019
...ny/Component/Security/Http/Tests/Firewall/UsernamePasswordFormAuthenticationListenerTest.php
Show resolved
Hide resolved
...ny/Component/Security/Http/Tests/Firewall/UsernamePasswordFormAuthenticationListenerTest.php
Show resolved
Hide resolved
OskarStark
approved these changes
Feb 22, 2019
nicolas-grekas
approved these changes
Feb 23, 2019
nicolas-grekas
changed the title
|
Thank you @PReimers. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 23, 2019
This PR was squashed before being merged into the 3.4 branch (closes #30347). Discussion ---------- [Security] Change FormAuthenticator if condition | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30341 | License | MIT | Doc PR | - I changed the if condition in `SimpleFormAuthenticationListener` and `UsernamePasswordFormAuthenticationListener` based on the solution provided by @nikic in issue #30341 #OpenSourceFriday Commits ------- 67ae121 [Security] Change FormAuthenticator if condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the if condition in
SimpleFormAuthenticationListenerandUsernamePasswordFormAuthenticationListenerbased on the solution provided by @nikic in issue #30341#OpenSourceFriday