[Validator] Fixed duplicate UUID #30324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Validator
Bug
and removed
Status: Needs Review
labels
fabpot
approved these changes
Feb 21, 2019
|
Thank you @ralfkuehnel. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Fixed duplicate UUID | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30285 | License | MIT | Doc PR | N/A Fixes the `TOO_HIGH_ERROR` constant had the same value in two different constraints: `LessThan` and `LessThanOrEqual`. Commits ------- 0bd5dd8 [Validator] Fixed duplicate UUID
|
Thanks Ralf! If you did this change cloning the repo on your local machine and working with Git in your terminal, I'd love to know if you had any problem. Also, if you followed the Symfony contribution guide, I'd like to know if there was any confusing instruction on it. If you have any comments, you can reach me via email or Slack. Thanks again for your contribution! |
|
@javiereguiluz I have followed the Symfony contribution guide to make the change on my local machine! It was straight forward, no problems! Already looking forward to make my next contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
TOO_HIGH_ERRORconstant had the same value in two different constraints:LessThanandLessThanOrEqual.