Remove unnecessary ProgressBar stdout writes (fixes flickering) #30278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
force-pushed
the
progressbar-flickering
branch
from
94aa211
to
3fbcb96
Compare
fabpot
approved these changes
Feb 17, 2019
|
Thank you @ostrolucky. |
fabpot
added a commit
that referenced
this pull request
Feb 17, 2019
…ring) (ostrolucky) This PR was merged into the 3.4 branch. Discussion ---------- Remove unnecessary ProgressBar stdout writes (fixes flickering) | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Currently ProgressBar flickers when writing a lot.  This patch fixes it and it's buttery smooth now. Additionally, this improves performance by 60%. Test code ```php $maxSteps = 1000000; $progressBar = new ProgressBar(new ConsoleOutput(), $maxSteps); for ($i=0; $i<= $maxSteps; $i++) { $progressBar->advance(); } ``` Commits ------- 3fbcb96 Remove unnecessary ProgressBar stdout writes (fixes flickering)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ProgressBar flickers when writing a lot.
This patch fixes it and it's buttery smooth now.
Additionally, this improves performance by 60%. Test code